Bug #5613

bug for reports of other plugin

Added by yllen 20 days ago. Updated 20 days ago.

Status:ResolvedStart date:11/12/2020
Priority:NormalDue date:
Assignee:yllen% Done:

100%

Category:-
Target version:1.14.1

Description

Dear Nelly,

I found a bug/typo introduced in the last release of the GLPI Additional Reports plugin, but I’m not able to post any new ticket in forge.glpi-project.org, so I try to write directly to you:

In inc/function.php line#68 was changed for compatibility to GLPI 9.5,

however, this:

$prefix = Plugin::getPhpDir('repots'). "/plugins/$plugin/report/". $report_name ."/" . $report_name;

Should be corrected to

$prefix = Plugin::getPhpDir('reports'). "/report/". $report_name ."/" . $report_name;

This is needed for new custom reports to find the language file.

https://forge.glpi-project.org/projects/reports/repository/diff/tags/1.14.0-GLPI_9.5/inc/function.php?utf8=%E2%9C%93&rev=386&rev_to=370

Moreover, ~10 lines below there is an error output commented as “for development” which writes lots of lines to the log, and should maybe be removed imho.

I thank you very much already if you are able to bring this change to the code.

Best regards

Mirko

Associated revisions

Revision 388
Added by yllen 20 days ago

fixed #5613

History

#1 Updated by yllen 20 days ago

  • Target version set to 1.14.1

#2 Updated by yllen 20 days ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset r388.

Also available in: Atom PDF